On 6 June 2013 09:10, Xiaoguang Chen <chenxg.marvell@xxxxxxxxx> wrote: > Yes, I missed the governor start in the end. > There is still a chance that After governor stop but before governor start, > cpu0 tries to set frequency through userspace governor, it will fail. > This should be the same problem I described to you before that > governor stop and start > should be protected by a lock to keep it in sequence and no body > should interrupt. > It seems we need to use the same lock for userspace governor set > freuqency to delay freq_set until > governor is started. Maybe we have one more option other than locking the sequence. Use locks properly in governor and a mechanism similar to cpu_is_managed from userspace governor. If we aren't managed now or governor isn't enabled for cpu return -EBUSY. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html