On Tue, Apr 02, 2013 at 11:01:24PM +0200, Borislav Petkov wrote: > On Tue, Apr 02, 2013 at 10:51:51PM +0200, Thomas Renninger wrote: > > powersave_bias is undocumented in Documentation/cpu-freq/... > > I guess its use-case is for people who want to get some percent more > > power savings out of their laptop and do not care of the one or other > > percent performance. > > In fact I would like to get rid of this extra code and I expect nobody would > > miss it. > > I might miss a configuration tool where someone went through the code, > > documented things and allows users to set powersave_bias values through > > some /etc/* config files. > > Yep, if you want anyone to make use of this, it should better get > > embedded in more general, at least general ondemand code. > > Yeah, it all sounds like we want to enable this by default on systems > which support it. Maybe with an off-switch for people who want plain > ondemand decisions. > > The remaining systems with ripped out powersave_bias would get plain > ondemand governor decisions. Provided, of course, nobody uses > powersave_bias and the functionality doesn't make any sense anyway. Rafael, any thoughts on removing powersave_bias altogether ? If we remove it, then is it acceptable to add an alternate callback/ handler registration to ondemand governor to account for hardware feedback ? Or, if we don't want to remove powersave_bias, Then Thomas, Boris, would it be acceptable if enable the frequency feedback feature by default with a sane powersave_bias tunable value ? And also add proper documentation for both vanila powersave_bias and powersave_bias with AMD frequency sensitivity loaded to Documentation/cpu-freq/ondemand ? > > Thanks. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- > -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
