On Tue, Jul 24, 2012 at 12:25 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > On Monday, July 23, 2012, Amit Daniel Kachhap wrote: >> On 23 July 2012 15:53, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >> >> > On Monday, July 23, 2012, Amit Daniel Kachhap wrote: >> > > This patch initialises the cpu field of this_dbs_info structure. This >> > > change is similar to existing ondemand governor. >> > >> > Why do you think the change is needed? >> > >> > Rafael >> > >> >> I agree that this field is not used anywhere currently but I was trying to >> perform some experiments and then this un-initialised field caused issues >> so i thought of fixing this up. > > So perhaps please write in the changelog that this is to keep governors > consistent with each other or something like this. Without explanation it > looks pointless. Ok sure, Will resend the patch with proper change logs. > > Thanks, > Rafael > > >> > > Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> >> > > --- >> > > drivers/cpufreq/cpufreq_conservative.c | 1 + >> > > 1 files changed, 1 insertions(+), 0 deletions(-) >> > > >> > > diff --git a/drivers/cpufreq/cpufreq_conservative.c >> > b/drivers/cpufreq/cpufreq_conservative.c >> > > index 235a340..a1563d7 100644 >> > > --- a/drivers/cpufreq/cpufreq_conservative.c >> > > +++ b/drivers/cpufreq/cpufreq_conservative.c >> > > @@ -504,6 +504,7 @@ static int cpufreq_governor_dbs(struct >> > cpufreq_policy *policy, >> > > j_dbs_info->prev_cpu_nice = >> > > >> > kcpustat_cpu(j).cpustat[CPUTIME_NICE]; >> > > } >> > > + this_dbs_info->cpu = cpu; >> > > this_dbs_info->down_skip = 0; >> > > this_dbs_info->requested_freq = policy->cur; >> > > >> > > >> > >> > >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
