On Tue, Aug 02, 2011 at 04:21:16PM -0400, Len Brown wrote: > While this patch will work and is not invalid, I don't like it. > > It advertises a user I/F that suggests that disabling turbo > is on a per logical processor basis -- but a write to > any of the attributes will write to every CPU in the system. > > Either it should do per-cpu limiting (which, btw doesn't > work if you use the MISC_ENABLES MSR method in this patch, > and would instead need to use the PERF_CTL.32 method) > or there should be a per-system attribute > that reflects that this knob is per-system. Agreed with the per-system thing. The reason to disable boosting on all cores is very simple: nobody has come up with a usecase until now which needs disabling only a subset of the cores. Also, this way the implementation is the simplest. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
