On Thu, 2009-05-21 at 19:47 -0400, Dave Jones wrote: > I just think it's a less readable variant of the same thing. > The shouty macro, the extra level of brackets, the whole thing > just seems to be ugly to me with no redeeming feature. > > What does doing this change really bring us? The ability to use pr_<foo> types rather than printk_once(KERN_<foo> and have the pr_fmt macro function correctly. DO_ONCE(pr_info( vs printk_once(KERN_INFO -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html