Re: [PATCH] corosync-quorumtool: sort nodes by nodeid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/08/14 13:42, Christine Caulfield wrote:
On 15/08/14 12:42, Fabio M. Di Nitto wrote:
On 08/14/2014 03:47 PM, Christine Caulfield wrote:
This is a silly thing that's bugged me for a while. corosync-quorumtool
always prints nodes out in IP address order which is not necessarily
node ID order. This can make the output confusing.

This patch forces node ID order. I'm also considering making sort order
a command-line option with selections for IP address, node ID and name.
Thoughts?

No objections, but please make it an option right away. I prefer to see
IP vs nodeids (that's also probably why I wrote it that way :)

Fabio

OK, here's the patch for making it an option. I can use this for the
sort by name bit that will come later :-) The default returns to ipaddr.


Ignore that patch. I've just spotted a bug in my original patch that will cause it to segv if used on a system with a quorum provider other than votequorum. The fix is best incorporated into the patch that also adds node name sorting as it means adding an enclosing structure to the two existing ones..

Chrissie

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss




[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux