Re: [PATCH 2/3] Fix cppchecks warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK


On 13/01/14 14:00, Jan Friesse wrote:
Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
---
  exec/cmap.c        |    4 ++--
  exec/main.c        |    4 ++--
  exec/totemconfig.c |    6 +++---
  3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/exec/cmap.c b/exec/cmap.c
index 78915c7..d222740 100644
--- a/exec/cmap.c
+++ b/exec/cmap.c
@@ -597,8 +597,8 @@ static void message_handler_req_lib_cmap_iter_next(void *conn, const void *messa
  	struct res_lib_cmap_iter_next res_lib_cmap_iter_next;
  	cs_error_t ret;
  	icmap_iter_t *iter;
-	size_t value_len;
-	icmap_value_types_t type;
+	size_t value_len = 0;
+	icmap_value_types_t type = 0;
  	const char *res = NULL;
  	struct cmap_conn_info *conn_info = (struct cmap_conn_info *)api->ipc_private_data_get (conn);

diff --git a/exec/main.c b/exec/main.c
index 84c3eac..322e9ff 100644
--- a/exec/main.c
+++ b/exec/main.c
@@ -562,8 +562,8 @@ static void totem_dynamic_notify(
  	void *user_data)
  {
  	int res;
-	int ring_no;
-	int member_no;
+	unsigned int ring_no;
+	unsigned int member_no;
  	struct totem_ip_address member;
  	int add_new_member = 0;
  	int remove_old_member = 0;
diff --git a/exec/totemconfig.c b/exec/totemconfig.c
index de63043..c17c673 100644
--- a/exec/totemconfig.c
+++ b/exec/totemconfig.c
@@ -292,7 +292,7 @@ static int find_local_node_in_nodelist(struct totem_config *totem_config)
  	icmap_iter_t iter;
  	const char *iter_key;
  	int res = 0;
-	int node_pos;
+	unsigned int node_pos;
  	int local_node_pos = -1;
  	struct totem_ip_address bind_addr;
  	int interface_up, interface_num;
@@ -343,7 +343,7 @@ static void put_nodelist_members_to_config(struct totem_config *totem_config)
  	icmap_iter_t iter, iter2;
  	const char *iter_key, *iter_key2;
  	int res = 0;
-	int node_pos;
+	unsigned int node_pos;
  	char tmp_key[ICMAP_KEYNAME_MAXLEN];
  	char tmp_key2[ICMAP_KEYNAME_MAXLEN];
  	char *node_addr_str;
@@ -394,7 +394,7 @@ static void config_convert_nodelist_to_interface(struct totem_config *totem_conf
  	icmap_iter_t iter;
  	const char *iter_key;
  	int res = 0;
-	int node_pos;
+	unsigned int node_pos;
  	char tmp_key[ICMAP_KEYNAME_MAXLEN];
  	char tmp_key2[ICMAP_KEYNAME_MAXLEN];
  	char *node_addr_str;


_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss




[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux