Re: [PATCH] Allocate cpg_dispatch message buffer in heap instead of stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



José Orlando Pereira napsal(a):
> On Wednesday 17 April 2013 19:41:38 José Orlando Pereira wrote:
>> I'm still trying to understand why.
> 
> After running it under strace, I see that upon free() we get a madvise(DONTNEED). Is it
> possible that when kernel is copying data into that block, it might simply be mapping in
> buffer pages, giving us zero copy for free?

Kernel is magic so almost everything is possible. But to your patch.
What about storing dispatch_buf inside cpg_inst? So then, you will
allocate dispatch_buf only once in cpg_model_initialize and free it
inside cpg_finalize? This should solve your problem + no performance hit
possible.

Also I really really like your project. Do you have any plans to
integrate other libraries as well? Like cmap may be very interesting
(ideally something implementing map interface), quorum (there is
basically only one callback interesting), ...

Regards,
  Honza

> 
> 
> 
> _______________________________________________
> discuss mailing list
> discuss@xxxxxxxxxxxx
> http://lists.corosync.org/mailman/listinfo/discuss
> 

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss





[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux