Re: [PATCH] Allocate cpg_dispatch message buffer in heap instead of stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 17 April 2013 19:38:46 Fabio M. Di Nitto wrote:
> On 4/17/2013 6:41 PM, José Orlando Pereira wrote:
> > On Wednesday 17 April 2013 17:38:40 Fabio M. Di Nitto wrote:
> >>
> >> The patch is better.
> >>
> >> Did you verify the performance impact of switching from static to malloc?
> >>
> >> there is a test/cpgbench you can use.
> > 
> > Actually cpgbench doesn't show the overhead, as it uses CS_DISPATCH_BLOCKING. After
> > changing the following in cpgbench.c:
> > 
> > -       cpg_dispatch (handle, CS_DISPATCH_BLOCKING);
> > +       while(1) cpg_dispatch (handle, CS_DISPATCH_ONE);
> > 
> > I'm getting mixed results (worse for 64 bytes, better but unstable for 8k
> > and 40k). I'll investigate further and let you know.
> 
> Ok, try the basic:
> 
> CS_DISPATCH_ONE with|without your patch and see if you notice the same
> mixed results (might be that we need to adapt the test suite to measure
> your patch).

That's what I have been doing. Using CS_DISPATCH_ONE in a loop and confirming that
there are no errors reported. Without the patch:

1274216 messages received    64 bytes per write  10.000 Seconds runtime 127420.504 TP/s   8.155 MB/s.
913165 messages received   320 bytes per write  10.000 Seconds runtime 91313.158 TP/s  29.220 MB/s.
388160 messages received  1600 bytes per write  10.000 Seconds runtime 38815.282 TP/s  62.104 MB/s.
119352 messages received  8000 bytes per write  10.000 Seconds runtime 11935.158 TP/s  95.481 MB/s.
31492 messages received 40000 bytes per write  10.000 Seconds runtime  3149.188 TP/s 125.968 MB/s.
 7520 messages received 200000 bytes per write  10.000 Seconds runtime   752.097 TP/s 150.419 MB/s.
 1446 messages received 1000000 bytes per write  10.000 Seconds runtime   144.599 TP/s 144.599 MB/s.

With the patch:

534997 messages received    64 bytes per write  10.000 Seconds runtime 53498.500 TP/s   3.424 MB/s.
532639 messages received   320 bytes per write  10.000 Seconds runtime 53263.052 TP/s  17.044 MB/s.
516788 messages received  1600 bytes per write  10.000 Seconds runtime 51678.919 TP/s  82.686 MB/s.
501374 messages received  8000 bytes per write  10.000 Seconds runtime 50137.505 TP/s 401.100 MB/s.
517638 messages received 40000 bytes per write  10.000 Seconds runtime 51763.934 TP/s 2070.557 MB/s.
152837 messages received 200000 bytes per write  10.000 Seconds runtime 15283.630 TP/s 3056.726 MB/s.
 1343 messages received 1000000 bytes per write  10.000 Seconds runtime   134.299 TP/s 134.299 MB/s.

I'm still trying to understand why.

-- 
Jose Orlando Pereira

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss

[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux