Re: [PATCH] Remove unchecked return error in test code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Jan Friesse <jfriesse@xxxxxxxxxx>

Steven Dake wrote:
> Signed-off-by: Steven Dake <sdake@xxxxxxxxxx>
> ---
>  cts/agents/sam_test_agent.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/cts/agents/sam_test_agent.c b/cts/agents/sam_test_agent.c
> index 604cbc6..9e681be 100644
> --- a/cts/agents/sam_test_agent.c
> +++ b/cts/agents/sam_test_agent.c
> @@ -1471,8 +1471,13 @@ static void do_command (int sock, char* func, char*args[], int num_args)
>  	} else if (strcmp ("setup_hc", func) == 0) {
>  		err = setup_hc ();
>  	} else if (strcmp ("sam_stop", func) == 0) {
> -		sam_stop ();
> -		sam_finalize();
> +		err = sam_stop ();
> +		if (err != CS_OK) {
> +			err = -1;
> +			syslog (LOG_ERR,"%s RPC:%s sam_stop failed!", __func__, func);
> +			snprintf (response, 100, "%s", FAIL_STR);
> +		}
> +		err = sam_finalize();
>  	} else {
>  		err = -1;
>  		syslog (LOG_ERR,"%s RPC:%s not supported!", __func__, func);

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux