On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > +void gfs2_glock_hold(struct gfs2_glock *gl) > +{ > + glock_hold(gl); > +} > > eh why? You removed the comment stating exactly why, see below. If that's not a accepted technique in the kernel, say so and I'll be happy to change it here and elsewhere. Thanks, Dave static inline void glock_hold(struct gfs2_glock *gl) { gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) > 0); atomic_inc(&gl->gl_count); } /** * gfs2_glock_hold() - As glock_hold(), but suitable for exporting * @gl: The glock to hold * */ void gfs2_glock_hold(struct gfs2_glock *gl) { glock_hold(gl); } -- Linux-cluster@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/linux-cluster