On 4/6/23 05:45, Christian Brauner wrote:
On Fri, Mar 31, 2023 at 10:50:43AM -0400, Waiman Long wrote:By default, the clone(2) syscall spawn a child process into the same cgroup as its parent. With the use of the CLONE_INTO_CGROUP flag introduced by commit ef2c41cf38a7 ("clone3: allow spawning processes into cgroups"), the child will be spawned into a different cgroup which is somewhat similar to writing the child's tid into "cgroup.threads". The current cpuset_fork() method does not properly handle the CLONE_INTO_CGROUP case where the cpuset of the child may be different from that of its parent. Update the cpuset_fork() method to treat the CLONE_INTO_CGROUP case similar to cpuset_attach(). Since the newly cloned task has not been running yet, its actual memory usage isn't known. So it is not necessary to make change to mm in cpuset_fork(). Fixes: ef2c41cf38a7 ("clone3: allow spawning processes into cgroups") Signed-off-by: Waiman Long <longman@xxxxxxxxxx> ---Just two nits. I think this needs a Cc stable and it would be nice if you could give Giuseppe a "Reported-by".
The presence of a fixes tag should make this patch picked up by stable. Yes, I will cc stable when I need to update the patch next time.
Right, I should have added Reported-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx> Cheers, Longman
