Hi, Tejun on 12/1/2022 5:36 AM, Tejun Heo wrote: > On Tue, Nov 29, 2022 at 11:01:47AM +0800, Kemeng Shi wrote: >> Function throtl_hierarchy_can_upgrade will always return from while loop, >> so the return outside while loop is never reached. Break the loop when >> we traverse to root as throtl_hierarchy_can_downgrade do to avoid dead >> code. > > I don't know why this is an improvement. > I just found that the "return false" outside of the while loop is never executed which may be not reached by code coverage test. Of course, we can simply remove this "return false", but I found a similar function throtl_hierarchy_can_upgrade which has no such problem. So I avoid unreachable code as throtl_hierarchy_can_upgrade do. Is this make sense to you? If not, I will remove this patch in next version. Thanks. -- Best wishes Kemeng Shi
