On Mon, May 30, 2022 at 03:49:09PM +0800, Muchun Song wrote:
> Since no-hierarchy mode is deprecated after
>
> commit bef8620cd8e0 ("mm: memcg: deprecate the non-hierarchical mode")
>
> so parent_mem_cgroup() cannot return a NULL except root memcg, however, root
> memcg cannot be offline, so it is safe to drop the check of returned value
> of parent_mem_cgroup(). Remove those dead code.
>
> The comments in memcg_offline_kmem() above memcg_reparent_list_lrus() are
> out of date since
>
> commit 5abc1e37afa0 ("mm: list_lru: allocate list_lru_one only when needed")
>
> There is no ordering requirement between memcg_reparent_list_lrus() and
> memcg_reparent_objcgs(), so remove those outdated comments.
>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Acked-by: Roman Gushchin <roman.gushchin@xxxxxxxxx>
Nice cleanup!
