Re: [PATCH v3] mm: hugetlb controller for cgroups v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Koutný <mkoutny@xxxxxxxx> writes:

> 1) Is that on purpose that the events_file (and hence notifications) are
> shared across various huge page sizes?
>
> 2) Note that page_counter_try_charge checks hierarchically all counters
> (not just the current h_cg's) and the limit may also be hit in an
> ancestor (the third argument). I.e. the notification should be triggered
> in the cgroup that actually crossed the limit.
>
> Furthermore, the hierarchical and local events. I suggest looking at
> memcg_memory_event for comparison.
>
> If I take one step back. Is there a consumer for these events? I can see
> the reasoning is the analogy with memcg's limits and events [1] but
> wouldn't be a mere .stats file enough?

just an error on my side.  Thanks for the hint, I'll take a look at the
existing controller.  If everyone agrees I'll split events in two files:

- hugetlb.<SIZE>.events
- hugetlb.<SIZE>.events.local

Giuseppe





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux