Mike Kravetz <mike.kravetz@xxxxxxxxxx> writes: > On 12/3/19 6:46 AM, Michal Koutný wrote: >> Hello. >> >> On Wed, Nov 27, 2019 at 01:44:46PM +0100, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: >>> - hugetlb.<hugepagesize>.current >>> - hugetlb.<hugepagesize>.max >>> - hugetlb.<hugepagesize>.events >> Just out of curiosity (perhaps addressed to Mike), does this naming >> account for the potential future split between reservations and >> allocations charges? > > Mina has been working/pushing the effort to add reservations to cgroup > accounting and would be the one to ask. However, it does seem that the > names here should be created in anticipation of adding reservations in > the future. So, perhaps something like: > > hugetlb_usage.<hugepagesize>.current > > with the new functionality having names like > > hugetlb_reserves.<hugepagesize>.current that seems to be very different than other cgroup v2 file names. Should it be something like? hugetlb.<hugepagesize>.current_usage hugetlb.<hugepagesize>.current_reserves Alternatively, could we make hugetlb.<hugepagesize>.current a flat-keyed file (or rename to .stat) so it can be easily extended in future? Giuseppe
