On Mon, Oct 01, 2012 at 04:52:13PM -0400, Jeff Moyer wrote: > Vivek Goyal <vgoyal@xxxxxxxxxx> writes: > > > At quite a few places we use the keyword "service_tree" and I feel that > > names in CFQ are already very long and they need to be shortened a bit > > where appropriate. > > > > So this patch just renames "service_tree" to "st" at most of the places. > > No functionality change. > > NACK. > > > - struct cfq_rb_root service_trees[2][3]; > > - struct cfq_rb_root service_tree_idle; > > + struct cfq_rb_root sts[2][3]; > > + struct cfq_rb_root st_idle; > > Honestly, who looks at sts and thinks "service trees?" Yes this one is little odd. Ok, I will change it back to "service_tree" and only use "st" for local variables and in some function names. Vivek -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
