On Mon, Oct 01, 2012 at 04:50:37PM -0400, Jeff Moyer wrote: > Vivek Goyal <vgoyal@xxxxxxxxxx> writes: > > > Also at places I have got rid of keyword "serving" as it is obivious. > > I don't agree with getting rid of serving. After your patch, it looks > as though a cfqd has a static workload class and type. It reads better > to me the way it is. It is also about the length of name. To me now a days CFQ code looks pretty messy with very long names or lines at many a places. So yes, "cfqd->serving_wl_class" and "cfqd->serving_wl_type" is more readable than "cfqd->wl_class" and "cfqd->wl_type". But it also increases the string length significantly. I don't know. Some of the strings seem too long and code spills into multiple lines for a single statement. Anyway, for this I guess I will retain "serving" keyword. Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
