On Tue, Apr 16, 2019 at 6:03 PM Paul Emmerich <paul.emmerich@xxxxxxxx> wrote: > > This works, it just says that it *might* require a restart, but this > particular option takes effect without a restart. We've already looked at changing the wording once to make it more palatable. http://tracker.ceph.com/issues/18424 > > Implementation detail: this message shows up if there's no internal > function to be called when this option changes, so it can't be sure if > the change is actually doing anything because the option might be > cached or only read on startup. But in this case this option is read > in the relevant path every time and no notification is required. But > the injectargs command can't know that. Right on all counts. The functions are referred to as observers and register to be notified if the value changes, hence "not observed." > > Paul > > On Mon, Apr 15, 2019 at 11:38 PM solarflow99 <solarflow99@xxxxxxxxx> wrote: > > > > Then why doesn't this work? > > > > # ceph tell 'osd.*' injectargs '--osd-recovery-max-active 4' > > osd.0: osd_recovery_max_active = '4' (not observed, change may require restart) > > osd.1: osd_recovery_max_active = '4' (not observed, change may require restart) > > osd.2: osd_recovery_max_active = '4' (not observed, change may require restart) > > osd.3: osd_recovery_max_active = '4' (not observed, change may require restart) > > osd.4: osd_recovery_max_active = '4' (not observed, change may require restart) > > > > # ceph -n osd.1 --show-config | grep osd_recovery_max_active > > osd_recovery_max_active = 3 > > > > > > > > On Wed, Apr 10, 2019 at 7:21 AM Eugen Block <eblock@xxxxxx> wrote: > >> > >> > I always end up using "ceph --admin-daemon > >> > /var/run/ceph/name-of-socket-here.asok config show | grep ..." to get what > >> > is in effect now for a certain daemon. > >> > Needs you to be on the host of the daemon of course. > >> > >> Me too, I just wanted to try what OP reported. And after trying that, > >> I'll keep it that way. ;-) > >> > >> > >> Zitat von Janne Johansson <icepic.dz@xxxxxxxxx>: > >> > >> > Den ons 10 apr. 2019 kl 13:37 skrev Eugen Block <eblock@xxxxxx>: > >> > > >> >> > If you don't specify which daemon to talk to, it tells you what the > >> >> > defaults would be for a random daemon started just now using the same > >> >> > config as you have in /etc/ceph/ceph.conf. > >> >> > >> >> I tried that, too, but the result is not correct: > >> >> > >> >> host1:~ # ceph -n osd.1 --show-config | grep osd_recovery_max_active > >> >> osd_recovery_max_active = 3 > >> >> > >> > > >> > I always end up using "ceph --admin-daemon > >> > /var/run/ceph/name-of-socket-here.asok config show | grep ..." to get what > >> > is in effect now for a certain daemon. > >> > Needs you to be on the host of the daemon of course. > >> > > >> > -- > >> > May the most significant bit of your life be positive. > >> > >> > >> > >> _______________________________________________ > >> ceph-users mailing list > >> ceph-users@xxxxxxxxxxxxxx > >> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com > > > > _______________________________________________ > > ceph-users mailing list > > ceph-users@xxxxxxxxxxxxxx > > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com > _______________________________________________ > ceph-users mailing list > ceph-users@xxxxxxxxxxxxxx > http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com -- Cheers, Brad _______________________________________________ ceph-users mailing list ceph-users@xxxxxxxxxxxxxx http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
 |