On Mon, Jun 28, 2021 at 01:25:41PM +0530, Venky Shankar wrote: > This series introduces changes Ceph File System mount device string. > Old mount device syntax (source) has the following problems: > > mounts to the same cluster but with different fsnames > and/or creds have identical device string which can > confuse xfstests. > > Userspace mount helper tool resolves monitor addresses > and fill in mon addrs automatically, but that means the > device shown in /proc/mounts is different than what was > used for mounting. > > New device syntax is as follows: > > cephuser@fsid.mycephfs2=/path > > Note, there is no "monitor address" in the device string. > That gets passed in as mount option. This keeps the device > string same when monitor addresses change (on remounts). > > Also note that the userspace mount helper tool is backward > compatible. I.e., the mount helper will fallback to using > old syntax after trying to mount with the new syntax. I haven't fully reviewed this patchset yet. I've started doing that (I'll send a few comments in a bit), but stopped when I found some parsing issues that need fixing. I gave these patches a quick test (with a not-so-up-to-date mount.ceph) and saw the splat below. Does this patchset depends on anything on the testing branch? I've tried it on v5.13 mainline. I also had a segmentation fault on the userspace mount. I've used something like: mount -t ceph admin@ef274016-6131-4936-9277-946b535f5d03.a=/ /mnt/test Cheers, -- Luís [ 7.847565] ------------[ cut here ]------------ [ 7.849322] kernel BUG at net/ceph/mon_client.c:209! [ 7.851151] invalid opcode: 0000 [#1] SMP PTI [ 7.852651] CPU: 1 PID: 188 Comm: mount Not tainted 5.13.0+ #32 [ 7.854698] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014 [ 7.858555] RIP: 0010:__open_session+0x186/0x210 [libceph] [ 7.860517] Code: 50 01 00 00 e8 db a9 ff ff 48 8b b3 50 01 00 00 48 89 ef 5b 5d 41 5c e9 68 b6 ff ff e8 43 8e 48 e1 31 d2 f7 f5 e9 c9 fe ff ff <0f> 0b 48 8b 43 08 41 b91 [ 7.866902] RSP: 0018:ffffc9000085fda0 EFLAGS: 00010246 [ 7.868736] RAX: ffff888114396520 RBX: 0000000000003a98 RCX: 0000000000000000 [ 7.871260] RDX: 0000000000000000 RSI: ffff88810eeec2a8 RDI: ffff88810eeec298 [ 7.873653] RBP: 0000000000000000 R08: 0000000000000008 R09: 0000000000000000 [ 7.875923] R10: ffffc9000085fdc0 R11: 0000000000000000 R12: 00000000ffffffff [ 7.878229] R13: ffff88811aef8500 R14: 00000000fffee289 R15: 7fffffffffffffff [ 7.880503] FS: 00007fda2ac9b800(0000) GS:ffff888237d00000(0000) knlGS:0000000000000000 [ 7.883088] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 7.884915] CR2: 00007f837ba61e88 CR3: 000000010fefc000 CR4: 00000000000006a0 [ 7.887174] Call Trace: [ 7.887920] ceph_monc_open_session+0x43/0x60 [libceph] [ 7.889502] __ceph_open_session+0x4b/0x250 [libceph] [ 7.891036] ceph_get_tree+0x41b/0x880 [ceph] [ 7.892337] vfs_get_tree+0x23/0x90 [ 7.893315] path_mount+0x73d/0xb20 [ 7.894291] __x64_sys_mount+0x103/0x140 [ 7.895387] do_syscall_64+0x45/0x80 [ 7.896324] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 7.897738] RIP: 0033:0x7fda2aeb617e [ 7.898886] Code: 48 8b 0d f5 1c 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 018 [ 7.903441] RSP: 002b:00007fff4b0d3e58 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 [ 7.905181] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fda2aeb617e [ 7.906813] RDX: 0000563e07b04c80 RSI: 0000563e07b04d20 RDI: 0000563e07b04ca0 [ 7.908506] RBP: 0000563e07b04960 R08: 0000563e07b04be0 R09: 00007fda2af78a60 [ 7.910176] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 [ 7.911830] R13: 0000563e07b04c80 R14: 0000563e07b04ca0 R15: 0000563e07b04960 [ 7.913480] Modules linked in: ceph libceph [ 7.914492] ---[ end trace 2798408fec037d5a ]--- [ 7.915582] RIP: 0010:__open_session+0x186/0x210 [libceph] [ 7.916853] Code: 50 01 00 00 e8 db a9 ff ff 48 8b b3 50 01 00 00 48 89 ef 5b 5d 41 5c e9 68 b6 ff ff e8 43 8e 48 e1 31 d2 f7 f5 e9 c9 fe ff ff <0f> 0b 48 8b 43 08 41 b91 [ 7.921090] RSP: 0018:ffffc9000085fda0 EFLAGS: 00010246 [ 7.922288] RAX: ffff888114396520 RBX: 0000000000003a98 RCX: 0000000000000000 [ 7.923875] RDX: 0000000000000000 RSI: ffff88810eeec2a8 RDI: ffff88810eeec298 [ 7.925323] RBP: 0000000000000000 R08: 0000000000000008 R09: 0000000000000000 [ 7.926822] R10: ffffc9000085fdc0 R11: 0000000000000000 R12: 00000000ffffffff [ 7.928320] R13: ffff88811aef8500 R14: 00000000fffee289 R15: 7fffffffffffffff [ 7.929790] FS: 00007fda2ac9b800(0000) GS:ffff888237d00000(0000) knlGS:0000000000000000 [ 7.931471] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 7.932579] CR2: 00007f837ba61e88 CR3: 000000010fefc000 CR4: 00000000000006a0
