On Mon, 2021-06-28 at 13:25 +0530, Venky Shankar wrote: > This series introduces changes Ceph File System mount device string. > Old mount device syntax (source) has the following problems: > > mounts to the same cluster but with different fsnames > and/or creds have identical device string which can > confuse xfstests. > > Userspace mount helper tool resolves monitor addresses > and fill in mon addrs automatically, but that means the > device shown in /proc/mounts is different than what was > used for mounting. > > New device syntax is as follows: > > cephuser@fsid.mycephfs2=/path > > Note, there is no "monitor address" in the device string. > That gets passed in as mount option. This keeps the device > string same when monitor addresses change (on remounts). > > Also note that the userspace mount helper tool is backward > compatible. I.e., the mount helper will fallback to using > old syntax after trying to mount with the new syntax. > > Venky Shankar (4): > ceph: new device mount syntax > ceph: validate cluster FSID for new device syntax > ceph: record updated mon_addr on remount > doc: document new CephFS mount device syntax > > Documentation/filesystems/ceph.rst | 23 ++++- > fs/ceph/super.c | 132 ++++++++++++++++++++++++++--- > fs/ceph/super.h | 4 + > include/linux/ceph/libceph.h | 1 + > net/ceph/ceph_common.c | 3 +- > 5 files changed, 149 insertions(+), 14 deletions(-) > Nice work, Venky. It needs a few minor changes, but this looks good overall. Unless anyone has objections or other suggestions for changes, we ought to aim to get this into the testing branch soon and aim for merging it in v5.15. Thoughts? -- Jeff Layton <jlayton@xxxxxxxxxx>
