On Fri, 2019-12-20 at 11:46 +0100, Ilya Dryomov wrote: > On Fri, Dec 20, 2019 at 10:21 AM Xiubo Li <xiubli@xxxxxxxxxx> wrote: > > On 2019/12/20 17:11, Ilya Dryomov wrote: > > > On Fri, Dec 20, 2019 at 1:44 AM <xiubli@xxxxxxxxxx> wrote: > > > > From: Xiubo Li <xiubli@xxxxxxxxxx> > > > > > > > > Just in case the session's refcount reach 0 and is releasing, and > > > > if we get the session without checking it, we may encounter kernel > > > > crash. > > > > > > > > Rename get_session to ceph_get_mds_session and make it global. > > > > > > > > Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx> > > > > --- > > > > > > > > Changed in V3: > > > > - Clean all the local commit and pull it and rebased again, it is based > > > > the following commit: > > > > > > > > commit 3a1deab1d5c1bb693c268cc9b717c69554c3ca5e > > > > Author: Xiubo Li <xiubli@xxxxxxxxxx> > > > > Date: Wed Dec 4 06:57:39 2019 -0500 > > > > > > > > ceph: add possible_max_rank and make the code more readable > > > Hi Xiubo, > > > > > > The base is correct, but the patch still appears to have been > > > corrupted, either by your email client or somewhere in transit. > > > > Ah, I have no idea of this now, I was doing the following command to > > post it: > > > > # git send-email --smtp-server=... --to=... > > Hrm, I've looked through my archives and the last non-mangled patch > I see from you is "[PATCH RFC] libceph: remove the useless monc check" > dated Oct 15. If you are using the same send-email command as before > and haven't changed anything on your end, it's probably one of the > intermediate servers... > > > And my git version is: > > > > # git --version > > git version 2.21.0 > > > > I attached it or should I post it again ? > > You attached the old version ;) It's not mangled, but it doesn't > apply. > > Jeff, are you getting Xiubo's patches intact? > Yep. This patch applied just fine using git-am. Patch looks reasonable to me -- I like guarding against a 0->1 transition on a refcount. I'll go ahead and push it to testing. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx>
