There are two main questions in my mind: A) when to build the image, and B) when to push it to a registry. A) I believe the image should be built as part of every ceph build. Whether it’s a local build or the official build, you will get the image as a build artifact. Today it’s a separate process to build the image. Is there any reason we can’t bring this in-tree instead of it being a separate process in ceph-container? At a minimum, a dev needs to be able to build an image from his local ceph build. B) The release builds should push the image to a public registry. The non-release builds just need to make the image available somewhere that the test infrastructure can pick it up. Rook does this by copying a tar to the test machines and importing to the local registry, but doesn’t push to a central registry. But I could see the need to push a candidate build to a registry where it can be picked up for broader testing. > On Nov 16, 2018, at 12:53 PM, Alfredo Deza <adeza@xxxxxxxxxx> wrote: > > On Fri, Nov 16, 2018 at 3:37 PM Sage Weil <sweil@xxxxxxxxxx> wrote: >> >> What would it take to create container images for development builds >> (i.e., ceph-ci branches)? >> >> Currently we don't need this for every branch, but it will be imporant >> very soon (if it isn't already) to build images for some branches in order >> to test changes targetting rook or ceph-ansible in container mode. IIRC >> the issues are >> >> 1- we probably don't want to push a container for every ceph-ci build onto >> docker hub, and we don't have a private container registry to push to > > This is the biggest hurdle IMO, we've tried in the past tinkering with > a registry and it was just too complex (Dan or Ken might have better > insight here). > >> >> 2- jenkins isn't triggering a container build for dev builds >> >> 3- jenkins isn't triggering a container build for release builds either. > > Seems like this is already done and they are being pushed to docker hub: > > https://github.com/ceph/ceph-container/issues/1200 > >> >> I'm guessing 3 is something we should just fix, so there's no human needed >> to get an up to date container into the public registries after a release. > > Actually both 2 and 3 wouldn't be that hard, I do think that the > registry is the biggest issue to tackle > >> >> For 1 and 2, perhaps a quick fix would be to trigger a build only if there >> is a keyword in the branch name (e.g., 'container')? That solves the >> immediate problem until we decide where to put images generated for every >> test build. >> >> Suggestions welcome! >> >> Thanks- >> sage >> >> >>
Attachment:
signature.asc
Description: Message signed with OpenPGP
