Luis Henriques <lhenriques@xxxxxxxx> writes: > Ilya Dryomov <idryomov@xxxxxxxxx> writes: <snip> > [ I still need to revisit those Op flags as I don't understand why I > assumed they would both be using CEPH_OSD_OP_FLAG_FADVISE_*. I > thought I saw a similar usage in the ceph code, but a quick grep > didn't show anything. ] Ok, I've took another look at this and I believe do_copy() (in file src/tools/rados/rados.cc) is what really confused me about these flags. This code seems to be using src/dst fadvise flags for the operation too. I've created a PR to fix it: https://github.com/ceph/ceph/pull/24561 Cheers, -- Luis
