If that'll improve latencies in the entire pull request review/test/merge process, then +1 from me, although it would probably help more if reviewers could go over PRs more often - It's not uncommon for PRs to not even get tagged for weeks, with actual, meaningful comments showing up even later because none of reviewers see that particular thing interesting or no one feels confident/competent enough to review them. -- Piotr Dałek piotr.dalek@xxxxxxxxxxxx https://ovhcloud.com/ -----Original Message----- From: ceph-devel-owner@xxxxxxxxxxxxxxx <ceph-devel-owner@xxxxxxxxxxxxxxx> On Behalf Of Sage Weil Sent: Thursday, October 11, 2018 4:03 PM To: ceph-devel@xxxxxxxxxxxxxxx Subject: automatically closing stale pull requests Should we enable a plugin like this? https://github.com/probot/stale It will let you configure a period of inactivity before a PR gets a message like This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. and another period before the PR is closed. We have a bazillion stale open PRs. :( My thinking is that ideally we really want something like this so tha thte open PRs reflect a real work queue. On the other hand, we also have a big backlog of open PRs that have valid fixes (or, indirectly, bug reports) that we probably need to go through and groom before actually closing PRs. Thoughts? sage
