Re: automatically closing stale pull requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I hear you Erwan.  It's really frustrating as a user to see "closed due to inactivity" messages for things that should get fixed.  How about something like a warning first:

"This issue will be automatically closed in 1 month if no further activity is detected" and then everyone including users with an active problem have the ability to at least insert a "I'm still having a problem!" comment that keeps it open?

Mark


On 10/11/2018 09:21 AM, Erwan Velu wrote:
There is a similar behavior on some bugzilla.

I have to admit that on the user side, that's sometimes a little bit raging when the stale is due to the lack of upstream support/review.

So the wording here is very important I think unless could feel like discouraged.

I personnaly have an open one because the maintainer never made what he proposed to do. So that one stalled and now the PR is surely unmeaningfull now.

So I read that part "It will be closed if no further activity occurs" as a little bit discouraging.

Why not having something like "If that issue still need work or interactions, please annotate it so it can be in our scope of active issues. If no interactions occurs for <insert delay>, this issue will be considered as inactive and then closed.".

Le 11/10/2018 à 16:03, Sage Weil a écrit :
Should we enable a plugin like this?

    https://github.com/probot/stale

It will let you configure a period of inactivity before a PR gets a
message like

      This issue has been automatically marked as stale because it has
           not had recent activity. It will be closed if no further
           activity occurs. Thank you for your contributions.

and another period before the PR is closed.

We have a bazillion stale open PRs.  :(

My thinking is that ideally we really want something like this so tha
thte open PRs reflect a real work queue.  On the other hand, we also have
a big backlog of open PRs that have valid fixes (or, indirectly, bug
reports) that we probably need to go through and groom before
actually closing PRs.

Thoughts?
sage





[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux