On Mon, 16 Jul 2018, David Zafman wrote: > Sage, > > I think we should disable osd_skip_data_digest instead. > > We should test and merge this in addition to 23052 > > https://github.com/ceph/ceph/pull/23084 Oh yeah, agreed, that's much better. I think we should still backport the fix in case the option gets reenabled for some reason. The skip_data_digest checks have no business in be_deep_scrub()! That doesn't have to make 13.2.1 tho. sage > > > David > > > On 7/16/18 10:06 AM, Sage Weil wrote: > > On Mon, 16 Jul 2018, Abhishek Lekshmanan wrote: > > > As we're finalizing mimic, please tag mimic-batch-1/reply in this > > > threadon any important prs that need to make this cut. Hopefully we can > > > handover to QE in a day or so. > > We will want https://github.com/ceph/ceph/pull/23052 but it's not in > > master yet. I'll try to get that tested today. > > > > sage > > -- > > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html