Instead of make check call for every pr, it could be a run test , which can have make check + other test, just running a higher level wrapper script would provide great flexibility in adding/removing other tests. On Fri, Jun 8, 2018 at 10:26 AM, David Zafman <dzafman@xxxxxxxxxx> wrote: > > I don't understand why but using teuthology-suite with --subset and > '--filter standalone' always generates 6 jobs. > > Since the filter runs after the subset, the rados suite always includes the > 6 standalone yamls for some reason. > > So a rados run should always be sufficient excluding the > ceph-objectstore-tool test. > > I withdraw my suggestion. However, people should try to be familiar with > run-standalone.sh because if it reproduces > > a problem it is a can be easier to debug and fix problems. I usually run > make check and run-standalone.sh on any core code changes > > before running teuthology. > > David > > > > On 6/8/18 9:54 AM, Alfredo Deza wrote: >> >> On Fri, Jun 8, 2018 at 11:10 AM, David Zafman <dzafman@xxxxxxxxxx> wrote: >>> >>> Sage, >>> >>> I suggest that a complete run-standalone.sh needs to pass before any code >>> review approvals on any core changes. This would have caught the latest >>> backfill issue before it got merged to master. >>> >>> I wonder if Jenkins could do it if the "core" label is applied to the >>> pull, >>> then it would be automatic. >> >> I don't think there is capabilities to trigger based on labels. The >> two options I see is to run always, or run based on a comment (we do >> this >> for rendering HTML from doc pull requests for example) >> >>> David >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
