Re: [PATCH 2/3] ceph: define argument structure for handle_cap_grant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Yan, Zheng" <zyan@xxxxxxxxxx> writes:

<snip>

> +struct cap_extra_info {
> +	struct ceph_string *pool_ns;
> +	u64 inline_version;
> +	void *inline_data;
> +	u32 inline_len;
> +	// currently issued

nit picking: I would rather have C-style comments.

> +	int issued;
> +};
> +
>  /*
>   * Handle a cap GRANT message from the MDS.  (Note that a GRANT may
>   * actually be a revocation if it specifies a smaller cap set.)
>   *
>   * caller holds s_mutex and i_ceph_lock, we drop both.
>   */
> -static void handle_cap_grant(struct ceph_mds_client *mdsc,
> -			     struct inode *inode, struct ceph_mds_caps *grant,
> -			     struct ceph_string **pns, u64 inline_version,
> -			     void *inline_data, u32 inline_len,
> -			     struct ceph_buffer *xattr_buf,
> +static void handle_cap_grant(struct inode *inode,
>  			     struct ceph_mds_session *session,
> -			     struct ceph_cap *cap, int issued)
> +			     struct ceph_cap *cap,
> +			     struct ceph_mds_caps *grant,
> +			     struct ceph_buffer *xattr_buf,
> +			     struct cap_extra_info *extra_info)
>  	__releases(ci->i_ceph_lock)
> -	__releases(mdsc->snap_rwsem)
> +	__releases(sesson->s_mdsc->snap_rwsem)
                   ^^^^^^
There's a typo here - it should be 'session'.

Cheers,
-- 
Luis
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux