On 04/09/2018 11:58 AM, Sage Weil wrote: > The mimic MOSDOp is modified to include qos_params in the encoding. > Before it's released, we need to either > > (1) ensure that qos_params looks how we expect it to look when we start > using it, so that we don't have to spend another feature bit to fix > it. > (2) remove it from mimic and re-add it right after. > > I'm leaning towards 2 since the parameter isn't actually used or usable in > mimic proper--it's only useful with the additional dmclock changes that > aren't merged yet. (Is that correct?) As discussed in the core meeting this morning, I agree that #2 is the way to go, and I'm working on the PR. Eric -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html