I don't think try_emplace solves the problem of avoiding the OSDShardPGSlot allocation since it is being allocated at the call site according to the commit in the OP. On Thu, Apr 5, 2018 at 5:09 AM, Jesse Williamson <jwilliamson@xxxxxxx> wrote: > On Wed, 4 Apr 2018, kefu chai wrote: > >> agreed, i think that's why try_emplace() was added in C++17. > > > Exactly. It avoids the move if there's no insertion. > > -Jesse > -- Cheers, Brad -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
