On Sat, Mar 17, 2018 at 12:02 AM, Alex Elder <elder@xxxxxxxxxx> wrote: > On 03/16/2018 07:37 AM, Alex Elder wrote: >> From: Ilya Dryomov <idryomov@xxxxxxxxx> >> >> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx> > > This is fine. But please provide a little more context. Why start them > at 1? Why make read the first one in an obj_operation_type? It's used as a type identifier, and starting at 1 makes it easier to spot uninitialized use when prototyping or debugging. No real reason for making read the first one, it just groups two modifying operations together. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html