On 03/16/2018 07:37 AM, Alex Elder wrote:
> From: Ilya Dryomov <idryomov@xxxxxxxxx>
>
> Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx>
This is fine. But please provide a little more context. Why start them
at 1? Why make read the first one in an obj_operation_type?
Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
> ---
> drivers/block/rbd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 4ca0a452d88e..883f17d6deeb 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -217,12 +217,14 @@ struct rbd_obj_request;
> typedef void (*rbd_obj_callback_t)(struct rbd_obj_request *);
>
> enum obj_request_type {
> - OBJ_REQUEST_NODATA, OBJ_REQUEST_BIO, OBJ_REQUEST_PAGES
> + OBJ_REQUEST_NODATA = 1,
> + OBJ_REQUEST_BIO,
> + OBJ_REQUEST_PAGES,
> };
>
> enum obj_operation_type {
> + OBJ_OP_READ = 1,
> OBJ_OP_WRITE,
> - OBJ_OP_READ,
> OBJ_OP_DISCARD,
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
