"Yan, Zheng" <ukernel@xxxxxxxxx> writes: > I also wish to do some optimization (incremental patches) to the code > > 1. avoid quota check if there is no quota in the filesystem. we can > use a variable to tracker how many snaprealm have quota enabled. I was thinking this should probably be an atomic64_t in struct ceph_mds_client. Does this make sense? Also, it would probably make sense to have the following functions as inline, defined in super.h: ceph_quota_is_max_files_exceeded ceph_quota_is_max_bytes_exceeded ceph_quota_is_max_bytes_approaching This way they could simply check the mdsc and return immediately if the counter is 0. > 2. save inode pointer (not increase inode's reference count) in > ceph_snap_realm data structure. so we can avoid calling > ceph_find_inode() in check_quota_exceeded() Would you like me to work on v5 to include these changes, or would you rather keep v4 and simply have 2 extra patches on top implementing these optimisations? Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
