"Yan, Zheng" <ukernel@xxxxxxxxx> writes: > On Fri, Jan 5, 2018 at 6:47 PM, Luis Henriques <lhenriques@xxxxxxxx> wrote: <snip> > Hi Luis. > > This series looks good. I will add them to our testing branch if my > local test goes well. Awesome, thanks a lot for your review. Please let me know if you find any issues during testing. > > I also wish to do some optimization (incremental patches) to the code > > 1. avoid quota check if there is no quota in the filesystem. we can > use a variable to tracker how many snaprealm have quota enabled. > 2. save inode pointer (not increase inode's reference count) in > ceph_snap_realm data structure. so we can avoid calling > ceph_find_inode() in check_quota_exceeded() Yeah, these changes seem to make sense. I'll have a look at them and see what I can come up with. Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
