> Op 19 oktober 2017 om 14:22 schreef John Spray <jspray@xxxxxxxxxx>: > > > On Mon, Oct 16, 2017 at 1:02 PM, Wido den Hollander <wido@xxxxxxxx> wrote: > > Hi, > > > > I completely overread this, but I just found out that osd_crush_location_hook was renamed to crush_location_hook in the new config style. > > > > When upgrading from Jewel to Luminous without touching your configuration OSDs will move to the default CRUSH location due to the hook not being executed. > > > > Was this an oversight with Luminous or was it intentional? > > Hmm, that setting wasn't part of the existing schema config_opts.h > schema. The init script was effectively treating it as a "magic" > value that ceph-conf would be able to read out of the text ceph.conf. > Not that that matters from a user POV! > > It looks like the init-ceph.in is still referring to the old magic > config setting's name as well. Yes, it was done by *ceph-osd-prestart.sh* which is executed by systemd under Jewel. > > I would vote that we treat this as a bug and change the setting name > back to osd_crush_location_hook, even if the name isn't quite > descriptive any more -- Sage? > Can't we alias it somehow? I ran into this with a pre-production cluster before we started the upgrade of two production systems. Problem is that this setting is usually only touched by large deployments so not very much tested nor used. Wido > John > > > > > Wido -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
