On 23/01/2017, Loic Dachary wrote: > Hi Adam, I don't know :-) Unless I'm mistaken the code in the linux > kernel is an unmodified copy of the code from src/crush/*.[ch]. I > however have no clue how it is tested to work as it should in both > contexts. Other than running integration tests with teuthology. > > How do you suggest we go about it ? I don't actually know. I just wondered, I had the vague impression that the CRUSH from Ceph was copied into the kernel but I didn't know who did it, if it was parallel development or a blanket copy or what. It /does/ mean that any changes to libcrush have to be kept as kernel compatible C code, which isn't bad, it's just good to make sure it's explicit. -- Senior Software Engineer Red Hat Storage, Ann Arbor, MI, US IRC: Aemerson@{RedHat, OFTC} 0x80F7544B90EDBFB9 E707 86BA 0C1B 62CC 152C 7C12 80F7 544B 90ED BFB9
Attachment:
signature.asc
Description: PGP signature