Re: master branch merges must pass unit tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 8, 2016 at 4:49 PM, Sage Weil <sweil@xxxxxxxxxx> wrote:
> I enabled the github check that the unit tests pass in order to merge to
> master.

Thank you!

> These tests still aren't completely reliable, but they're close,
> and we'll make better progress if we start enforcing it now.
>

I would like to see some effort put into make it more reliable. One of
the things that it has to do is reboot the box where it runs
to ensure that processes are really killed. I would love to see some
effort put into the targets to make them robust.

There is nothing too complicated going on at the CI level, we just
call run-make-check.sh:

https://github.com/ceph/ceph-build/blob/master/ceph-pull-requests/config/definitions/ceph-pull-requests.yml#L49

> Note that core developers can still override the check to merge if
> it's necessary, but I encourage you to avoid doing so!
>
> sage
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux