On 20-10-2016 02:21, Willem Jan Withagen wrote:
> On 19-10-2016 20:58, kefu chai wrote:
>> should have been fixed in master.
>
> Ehh,
>
> Not really.
> Just tested by running
> cd Ceph/master/ceph
> git pull
> ./do_freebsd.sh
>
> And I still get the same error.
>
> Guess I'll have to start bisecting to see where it went wrong.
This is the actual commit going wrong
commit c9c5235ef7d563b92f44dab63a8ac2b694e69d4f
Author: Sage Weil <sage@xxxxxxxxxx>
Date: Wed Sep 14 13:32:20 2016 -0400
include/object: conditional denc_traits for snapid_t
Signed-off-by: Sage Weil <sage@xxxxxxxxxx>
diff --git a/src/include/object.h b/src/include/object.h
index 74a011b..4532b78 100644
--- a/src/include/object.h
+++ b/src/include/object.h
@@ -122,6 +122,22 @@ struct snapid_t {
inline void encode(snapid_t i, bufferlist &bl) { encode(i.val, bl); }
inline void decode(snapid_t &i, bufferlist::iterator &p) {
decode(i.val, p); }
+template<>
+struct denc_traits<snapid_t> {
+ enum { supported = 2 };
+ enum { featured = false };
+ enum { bounded = true };
+ static void bound_encode(const snapid_t o, size_t& p) {
+ denc(o.val, p);
+ }
+ static void encode(const snapid_t &o,
buffer::list::contiguous_appender& p) {
+ denc(o.val, p);
+ }
+ static void decode(snapid_t& o, buffer::ptr::iterator &p) {
+ denc(o.val, p);
+ }
+};
+
inline ostream& operator<<(ostream& out, snapid_t s) {
if (s == CEPH_NOSNAP)
return out << "head";
But have not figure out why.
I'm going to give it some bedrest.
> --WjW
>
>
>> Willem Jan Withagen <wjw@xxxxxxxxxxx <mailto:wjw@xxxxxxxxxxx>>于2016年10
>> 月20日 周四00:10写道：
>>
>> I guess somebody recently modified the type of either the ::encode() or
>> snapid_t. But Clang now really throws a fit.
>>
>> --WjW
>>
>> /usr/srcs/Ceph/work/ceph/src/common/snap_types.h:58:5: error: no
>> matching function for call to 'encode'
>> ::encode(snaps, bl);
>> ^~~~~~~~
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:68:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const __u8' (aka 'const unsigned char') for 1st argument
>> WRITE_RAW_ENCODER(__u8)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:70:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const __s8' (aka 'const signed char') for 1st argument
>> WRITE_RAW_ENCODER(__s8)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:72:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const char' for 1st argument
>> WRITE_RAW_ENCODER(char)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:73:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const ceph_le64' for 1st argument
>> WRITE_RAW_ENCODER(ceph_le64)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:74:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const ceph_le32' for 1st argument
>> WRITE_RAW_ENCODER(ceph_le32)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:75:1: note: candidate
>> function not viable: no known conversion from 'const vector<snapid_t>'
>> to 'const ceph_le16' for 1st argument
>> WRITE_RAW_ENCODER(ceph_le16)
>> ^
>> /usr/srcs/Ceph/work/ceph/src/include/encoding.h:65:15: note: expanded
>> from macro 'WRITE_RAW_ENCODER'
>> inline void encode(const type &v, bufferlist& bl, uint64_t features=0)
>> { encode_raw(v, bl); } \
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
