On Fri, Aug 5, 2016 at 2:00 PM, Alfredo Deza <adeza@xxxxxxxxxx> wrote: > There is a tendency to embed dependencies in the Ceph project which is a big > problem for maintainers (there are many reasons for this, including security > patches, and keeping up to date with forks). For Mantle, this is the case > again: it depends on a Pull Request [1] that embeds a *forked* version of the > official Lua repository that includes custom changes. I think we should be using our own copy of the upstream tarballs. Is there no way to use Lua's Makefiles with our cmake build? > Here are a few concerns I have: > > * The fork is already modified and has diverged from the upstream Lua [2], who > is going to keep up with upstream changes? (pulling/rebasing etc...) The cmsgpack module should be in the ceph/ tree and added to the preload table: https://www.lua.org/manual/5.3/manual.html#pdf-require Scripts should then require "cmsgpack". > * Embedding Lua in this form makes it *impossible* for distro maintainers to > package Ceph: they would most likely rip out and figure out how to try and > make it work with the distro-provided version. *This is very frowned upon and > creates a gigantic amount of work for package maintainers*. We should definitely try to limit changes to Lua unless it's absolutely necessary. I haven't seen a good reason yet so I suggest using bare upstream so maintainers can use the system liblua if desired. -- Patrick Donnelly -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
