+1 for point 1 because If user wants to have checksum on they will probably want it both for read/write path IMO. Thanks & Regards Somnath -----Original Message----- From: ceph-devel-owner@xxxxxxxxxxxxxxx [mailto:ceph-devel-owner@xxxxxxxxxxxxxxx] On Behalf Of Igor Fedotov Sent: Friday, July 15, 2016 4:38 AM To: ceph-devel Subject: bluestore checksum enable/disable behavior Hi All, During read regression testing I realized that one can't disable checksum verification on read if corresponding blob was created with csum verification enabled. More detailed overview is below. We have "bluestore csum" flag in ceph config that currently enables/disables csum generation for blob writing only. It appeared that this flag has no impact on the read request handling. During blob reading we simply check whether csum tag is attached for the blob and verify csum if it's there. The question is if such behavior is OK or we need finer way to control csum verification on read? I can see a couple of ways to improve that. 1) Use "bluestore csum" flag during the reading too. 2) Introduce another flag ("bluestore csum on read"?) to have explicit control on read handling. Thus we'll have independent control on both read and write. The second way is more flexible but IMHO is an overkill hence I vote for 1). Any thoughts? Thanks, Igor -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). ��.n��������+%������w��{.n����z��u���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
