On 20-6-2016 02:27, Deepa Dinamani wrote: > CURRENT_TIME is not y2038 safe. > The macro will be deleted and all the references to it > will be replaced by ktime_get_* apis. > > struct timespec is also not y2038 safe. > Retain timespec for timestamp representation here as ceph > uses it internally everywhere. > These references will be changed to use struct timespec64 > in a separate patch. > > Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx> > Cc: "Yan, Zheng" <zyan@xxxxxxxxxx> > Cc: Sage Weil <sage@xxxxxxxxxx> > Cc: Ilya Dryomov <idryomov@xxxxxxxxx> > Cc: ceph-devel@xxxxxxxxxxxxxxx > --- > net/ceph/messenger.c | 6 ++++-- > net/ceph/osd_client.c | 4 ++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Hi Deepa, Although I applaud 64-bit timestamps, the ktime_get_* api seems to be a Linux only API. So IF ever things need to be the least bit portable, I suggest wrapping these routines into a class of itself. So that porting confines itself to only that class. (plus/minus hairy semantic details) For what is now committed the change is not really that big. On the other hand, I 'll have to start figuring out if FreeBSD really does do 64bit timestamps... So I would welcome a more elaborate description of the problem (it seems that Linux is going 64bit in its inodes??) and what is being fixed and how. So that in the porting case not only the code will be the source to figure out what is going on. Thanx, --WjW -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
