Re: cap mask differences for `Client::stat` vs `Client::fstat`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 13, 2016 at 10:26 AM, Noah Watkins <noahwatkins@xxxxxxxxx> wrote:
> In the libcephfs client it looks like both `Client::stat` and
> `Client::lstat` use a default mask of CEPH_STAT_CAP_INODE_ALL and are
> able to return immediately from `Client::_getattr` without making an
> MDS request. However, `Client::fstat` uses hard-coded -1 as the cap
> mask and always issues a MDS request. Is this the intended behavior,
> and if so, what are different semantics of fstat that make this a
> requirement?

Based off of "man fstat" and looking at the git history, I think this
is an accident. I certainly can't think of any reason why we'd need Fb
(for instance) in order to answer a stat request. Send in a PR? :)
-Greg
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux