On 31/03/2016 12:04, Willem Jan Withagen wrote: > On 31-3-2016 11:31, Loic Dachary wrote: >> >> >> On 30/03/2016 22:39, Willem Jan Withagen wrote: >>> On 30-3-2016 12:10, Loic Dachary wrote: >>>> Hi Willem, >>>> >>>> Would you mind proposing a pull request with that change ? It looks good to me. >>>> >>> >>> Loic, >>> >>> It does run from make. >>> >>> But just running it on the commandline, does not really deliver.... >>> >>> [/usr/srcs/Ceph/work/ceph/src] wjw@xxxxxxxxxxxxxxxxxxxx> >>> ceph-disk/run-tox.sh >>> ceph-disk/run-tox.sh: line 21: ceph-disk-virtualenv/bin/activate: No >>> such file or directory >>> ceph-disk/run-tox.sh: line 22: ceph-disk-virtualenv/tox.out: No such >>> file or directory >>> ceph-disk/run-tox.sh: line 24: ceph-disk-virtualenv/tox.out: No such >>> file or directory >>> >>> But perhaps the testscripts are not intended to run separate on the >>> commandline? >> >> They are. There still is something wrong... > > Anything I can do? modified src/ceph-disk/run-tox.sh @@ -16,7 +16,7 @@ # # run from the ceph-disk directory or from its parent -: ${CEPH_DISK_VIRTUALENV:=ceph-disk-virtualenv} +: ${CEPH_DISK_VIRTUALENV:=/tmp/ceph-disk-virtualenv} test -d ceph-disk && cd ceph-disk source ${CEPH_DISK_VIRTUALENV}/bin/activate tox > ${CEPH_DISK_VIRTUALENV}/tox.out 2>&1 Does it work with the above patch ? The default location of the virtualenv was changed but this default was not updated. Cheers -- Loïc Dachary, Artisan Logiciel Libre -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html