On Sat, Feb 20, 2016 at 9:05 PM, Ilya Dryomov <idryomov@xxxxxxxxx> wrote:
> On Sat, Feb 20, 2016 at 7:44 PM, Alex Elder <elder@xxxxxxxx> wrote:
>> +On 02/20/2016 10:45 AM, Ilya Dryomov wrote:
>>> ceph_msg_footer is 21 bytes long, while ceph_msg_footer_old is only 13.
>>> Don't skip too much when CEPH_FEATURE_MSG_AUTH isn't negotiated.
>>
>> This looks good, but I have a few suggestions.
>>
>> You could done some factoring in prepare_write_message_footer()
>> to use the new function for setting iov_len and updating
>> out_kvec_bytes.
>
> I considered it, but we'd still need the if on MSG_AUTH bit, so
> I decided it wasn't worth it. TBH I'm more inclined to rip this
> old_footer stuff entirely - it's supported since v0.55, that's
> pre-bobtail...
What I missed yesterday was that using sizeof_footer() makes it
possible to use con_out_kvec_add(). I updated 4/4 and also pulled the
need_sign -> sizeof_footer() hunk from 2/4 into it.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
