On 02/20/2016 02:05 PM, Ilya Dryomov wrote: >>> >> >>> >> +static size_t sizeof_footer(struct ceph_connection *con) >> > >> > I understand why this is named this way. But it's supplying a >> > connection as argument, but a footer is a message attribute. >> > So I might call this con_msg_footer_size(). > The *size* of footer is a connection attribute though ;) Yeah, I know. That's why I suggested the con_msg_***(). But in any case, the code looks correct regardless of the name. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
