Re: wip-addr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Marcus,

On Fri, 2 Oct 2015, Marcus Watts wrote:
> wip-addr
> 
> 1. where is it?
> 2. current state
> 3. more info
> 4. cheap fixes
> 5. in case you were wondering why?
> 
> ____ 1. where is it?
> 
> I've just pushed another update to wip-addr:
> 
> git@xxxxxxxxxx:linuxbox2/linuxbox-ceph.git
> wip-addr
> 
> ____ 2. current state
> 
> This version
> 1/ compiles
> 2/ ran an extremely limited set of tests successfully
> 	(was able to bring up ceph-mon, ceph-osd).
> 
> In theory, it should do everything a recent "master" branch copy of ceph
> can do and little or nothing past that.  Internally it adds "address vector"
> support, some parsing/print logic, and lots of encoding rules to pass them
> around, but there's nothing that can create and little that makes any
> sensible use of this.  So this is just the back end encoding and storage rules.

This is looking pretty good. I left some comments.  There are still a few 
XXX's left... but not many.  Haomai, can you help with the async msgr one? 
(Also, Marcus, can you check if the msg/Simple/Pipe.cc connect() and 
accept() code doing the right thing?)

One minor thing.. please put the subsystem as the prefix to the commit
message instead of the branch name (e.g., mds: add features to event 
types).

> Phase 2 is to add logic to actually make it useful.
> 	(the very start of this is on linuxbox2 "wip-addr-p2",
> 	just monmap changes so far...)
> ____ 3. more info
> 
> There's an etherpad document that describes this in more detail,
> 
> http://pad.ceph.com/p/wip_addr
> 
> ____ 4. cheap fixes
> 
> a couple of minor issues that should be easy to resolve,
> 1.
> AsyncConnection.cc
> this passes addresses back and forth as it's setting up the connection,
> and it also exchanges features.  As best I can tell, it looks like
> it exchanges addresses before it knows what features the other end
> supports.  There should be something in here that
> does this after knowing what features the other end supports.

Copying Haomai.
 
> 2.
> (about line 2067 in src/tools/ceph_objectstore_tool.cc)
> (use via ceph cmd?) tools - "object store tool".
> This has a way to serialize objects which includes a watch list
> which includes an address.  There should be an option here to say
> whether to include exported addresses.

I think it's safe to use defaults here.. what do you think, David?

Thanks!
sage

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux