On Mon, Sep 14, 2015 at 9:51 PM, Ilya Dryomov <idryomov@xxxxxxxxx> wrote: > We are the client, but advertise keepalive2 anyway - for consistency, > if nothing else. In the future the server might want to know whether > its clients support keepalive2. the kernel code still does fully support KEEPALIVE2 (it does not recognize CEPH_MSGR_TAG_KEEPALIVE2 tag). I think it's better to not advertise support for keepalive2. Regards Yan, Zheng > > Signed-off-by: Ilya Dryomov <idryomov@xxxxxxxxx> > --- > include/linux/ceph/ceph_features.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/ceph/ceph_features.h b/include/linux/ceph/ceph_features.h > index 4763ad64e832..f89b31d45cc8 100644 > --- a/include/linux/ceph/ceph_features.h > +++ b/include/linux/ceph/ceph_features.h > @@ -107,6 +107,7 @@ static inline u64 ceph_sanitize_features(u64 features) > CEPH_FEATURE_OSDMAP_ENC | \ > CEPH_FEATURE_CRUSH_TUNABLES3 | \ > CEPH_FEATURE_OSD_PRIMARY_AFFINITY | \ > + CEPH_FEATURE_MSGR_KEEPALIVE2 | \ > CEPH_FEATURE_CRUSH_V4) > > #define CEPH_FEATURES_REQUIRED_DEFAULT \ > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
