Yes, even today rocksdb also linked with tcmalloc. It doesn't mean all the application using rocksdb needs to be built with tcmalloc. Sage, Wanted to know is there any reason we didn't link client libraries with tcmalloc at the first place (but did link only OSDs/mon/RGW) ? Thanks & Regards Somnath -----Original Message----- From: Sage Weil [mailto:sage@xxxxxxxxxxxx] Sent: Saturday, August 22, 2015 6:56 AM To: Milosz Tanski Cc: Shishir Gowda; Somnath Roy; Stefan Priebe; Alexandre DERUMIER; Mark Nelson; ceph-devel Subject: Re: Ceph Hackathon: More Memory Allocator Testing On Fri, 21 Aug 2015, Milosz Tanski wrote: > On Fri, Aug 21, 2015 at 12:22 AM, Shishir Gowda > <Shishir.Gowda@xxxxxxxxxxx> wrote: > > Hi All, > > > > Have sent out a pull request which enables building librados/librbd with either tcmalloc(as default) or jemalloc. > > > > Please find the pull request @ > > https://github.com/ceph/ceph/pull/5628 > > > > With regards, > > Shishir > > Unless I'm missing something here, this seams like the wrong thing to. > Libraries that will be linked in by other external applications should > not have a 3rd party malloc linked in there. That seams like an > application choice. At the very least the default should not be to > link in a 3rd party malloc. Yeah, I think you're right. Note that this isn't/wasn't always the case, though.. on precise, for instance, libleveldb links libtcmalloc. They stopped doing this sometime before trusty. sage ________________________________ PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
