Re: [PATCHv2 0/3] rbd: header read/refresh improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alex,

Thanks for circling back.

We should prioritize correctness and accuracy over promptness here; this isn’t a critical feature and I’d like my first submission to receive a thorough review.

Thanks,
—Doug

> On May 7, 2015, at 11:28 AM, Alex Elder <elder@xxxxxxxx> wrote:
> 
> On 04/26/2015 11:40 PM, Alex Elder wrote:
>> On 04/26/2015 11:35 PM, Douglas Fuller wrote:
>>> This solution just feels hacky and inefficient, so I think there is a
>>> desire to feel like we at least tried to come up something simpler
>>> and more efficient before proceeding.
>> 
>> Right.  And somehow more fitting with the existing code, if
>> that's possible.  There are a few things in this proposal
>> that are just special case code, and it would be nice to
>> avoid that.
>> 
>> I'm sorry I've been too busy today to get back to this.  I spent
>> a lot of time on Saturday getting ramped back up on this code
>> so I could provide a decent review...
>> 
>> I'm going to at least look at the code (error on a read op)
>> before going to bed, so I at least know what the problem is.
>> I'll try to have something to say (even if it's "I've got
>> nothing") in the next day or two.
>> 
>>                    -Alex
> 
> It's been a week and a half since I sent this.  I don't
> expect to be able to contribute anything for at least a
> few more days.
> 
> If adding this functionality is something you need quickly,
> I don't want you to be waiting for me.
> 
> If you can wait, I will gladly review it and offer my
> suggestions for a better way (if I can think of one...).
> 
> But if not, you should just proceed with what you have
> if it solves the problem.
> 
> I just don't want to keep you waiting.
> 
> 					-Alex

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux